Improve ServerConnection class code coverage

Author: jacek-poreda-sonarsource

api/src/test/java/org/sonarsource/scanner/api/internal/ServerConnectionTest.java

@@ -22,6 +22,7 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.HashMap;
 import java.util.Map;
 import okhttp3.mockwebserver.MockResponse;
@@ -32,7 +33,9 @@
 import org.junit.rules.TemporaryFolder;
 import org.sonarsource.scanner.api.internal.cache.Logger;
 
+import static java.lang.String.format;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.mockito.Mockito.mock;
 
 public class ServerConnectionTest {
@@ -66,6 +69,16 @@ public void download_success() throws Exception {
     assertThat(response).isEqualTo(HELLO_WORLD);
   }
 
+  @Test
+  public void downloadString_fails_on_url_validation() {
+    ServerConnection connection = create(false, false);
+    answer(HELLO_WORLD);
+
+    assertThatThrownBy(() -> connection.downloadString("should_fail"))
+      .isInstanceOf(IllegalArgumentException.class)
+      .hasMessage("URL path must start with slash: should_fail");
+  }
+
   @Test
   public void test_downloadFile() throws Exception {
     Path toFile = temp.newFile().toPath();
@@ -77,6 +90,27 @@ public void test_downloadFile() throws Exception {
     assertThat(new String(Files.readAllBytes(toFile), StandardCharsets.UTF_8)).isEqualTo(HELLO_WORLD);
   }
 
+  @Test
+  public void downloadFile_fails_on_url_validation() {
+    ServerConnection connection = create(false, false);
+    answer(HELLO_WORLD);
+
+    assertThatThrownBy(() -> connection.downloadFile("should_fail", Paths.get("test-path")))
+      .isInstanceOf(IllegalArgumentException.class)
+      .hasMessage("URL path must start with slash: should_fail");
+  }
+
+  @Test
+  public void should_throw_ISE_if_response_not_successful() throws Exception {
+    Path toFile = temp.newFile().toPath();
+    answer(HELLO_WORLD, 400);
+
+    ServerConnection underTest = create(false, false);
+    assertThatThrownBy(() -> underTest.downloadFile("/batch/index.txt", toFile))
+      .isInstanceOf(IllegalStateException.class)
+      .hasMessage(format("Status returned by url [http://localhost:%d/batch/index.txt] is not valid: [400]", server.getPort()));
+  }
+
   @Test
   public void should_support_server_url_without_trailing_slash() throws Exception {
     Map<String, String> props = new HashMap<>();
@@ -104,7 +138,11 @@ private ServerConnection create(boolean enableCache, boolean preferCache) {
   }
 
   private void answer(String msg) {
-    MockResponse response = new MockResponse().setBody(msg);
+    answer(msg, 200);
+  }
+
+  private void answer(String msg, int responseCode) {
+    MockResponse response = new MockResponse().setBody(msg).setResponseCode(responseCode);
     server.enqueue(response);
   }
 }