Don't use new slf4j features to support Maven (and likely Gradle)

Author: henryju

lib/pom.xml

@@ -20,6 +20,8 @@
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
       <version>${slf4j.version}</version>
+      <!-- provided by the bootstrapper plugin context (Maven, Gradle) -->
+      <scope>provided</scope>
     </dependency>
     <dependency>
       <groupId>com.squareup.okhttp3</groupId>

lib/src/main/java/org/sonarsource/scanner/lib/ScannerEngineBootstrapper.java

@@ -95,7 +95,9 @@ public ScannerEngineBootstrapper setBootstrapProperty(String key, String value)
    * Bootstrap the scanner-engine.
    */
   public ScannerEngineFacade bootstrap() {
-    LOG.atDebug().addArgument(() -> FileUtils.byteCountToDisplaySize(Runtime.getRuntime().maxMemory())).log("Scanner max available memory: {}");
+    if (LOG.isDebugEnabled()) {
+      LOG.debug("Scanner max available memory: {}", FileUtils.byteCountToDisplaySize(Runtime.getRuntime().maxMemory()));
+    }
     initBootstrapDefaultValues();
     var properties = Map.copyOf(bootstrapProperties);
     var isSonarCloud = isSonarCloud(properties);

lib/src/main/java/org/sonarsource/scanner/lib/internal/JavaRunner.java

@@ -52,7 +52,9 @@ public boolean execute(List<String> args, @Nullable String input, Consumer<Strin
     try {
       List<String> command = new ArrayList<>(args);
       command.add(0, javaExecutable.toString());
-      LOG.atDebug().addArgument(() -> String.join(" ", command)).log("Executing: {}");
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Executing: {}", String.join(" ", command));
+      }
       Process process = new ProcessBuilder(command).start();
       if (input != null) {
         try (var stdin = process.getOutputStream(); var osw = new OutputStreamWriter(stdin, StandardCharsets.UTF_8)) {