feat(helpers): add document archiver#46
Open
itsjgf wants to merge 1 commit into
Open
Conversation
joshdmiller
requested changes
Sep 26, 2016
joshdmiller
left a comment
joshdmiller
left a comment
There was a problem hiding this comment.
This looks pretty good! I made one comment about a bit of code that I do not think will cause a problem, but is probably unnecessary.
We do need some unit tests, though.
| export function archiveDocument(collection, _id, userId) { | ||
| return this.flatMap(db => { | ||
| db = db.mongo.collection(collection); | ||
| return Observable.fromPromise(db.findOneAndUpdate( |
There was a problem hiding this comment.
On a flatMap, I don't think you need to call Observable.fromPromise. I think it should detect that it is a promise and resolve it automatically as part of the flatMap.
itsjgf
force-pushed
the
archive-node
branch
2 times, most recently
from
6cc2c4f to
c75afb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42 is necessary in order to merge this PR.
Closes #13
This change is