fix: Duplicated inline fragments that may miss aliases

Ref: #69

Author: Stranger6667

docs/changelog.rst

@@ -4,6 +4,10 @@ Changelog
 `Unreleased`_ - TBD
 -------------------
 
+**Fixed**
+
+- Duplicated inline fragments that may miss aliases. `#69`_
+
 `0.7.1`_ - 2022-04-27
 ---------------------
 
@@ -161,6 +165,7 @@ Invalid queries:
 .. _0.3.1: https://github.com/stranger6667/hypothesis-graphql/compare/v0.3.0...v0.3.1
 .. _0.3.0: https://github.com/stranger6667/hypothesis-graphql/compare/v0.2.0...v0.3.0
 
+.. _#69: https://github.com/Stranger6667/hypothesis-graphql/69
 .. _#57: https://github.com/Stranger6667/hypothesis-graphql/57
 .. _#51: https://github.com/Stranger6667/hypothesis-graphql/51
 .. _#49: https://github.com/Stranger6667/hypothesis-graphql/49

src/hypothesis_graphql/_strategies/strategy.py

@@ -18,6 +18,7 @@
 from .validation import maybe_parse_schema, validate_custom_scalars, validate_fields
 
 BY_NAME = operator.attrgetter("name")
+EMPTY_LISTS_STRATEGY = st.builds(list)
 
 
 def instance_cache(key_func: Callable) -> Callable:
@@ -131,7 +132,7 @@ def inline_fragments(self, items: List[graphql.GraphQLObjectType]) -> st.SearchS
         # then the resulting query should not have these fields simultaneously
         strategies, overlapping_fields = self.collect_fragment_strategies(items)
         if overlapping_fields:
-            return compose_interfaces_with_filter(st.just([]), strategies, self.schema.type_map)
+            return compose_interfaces_with_filter(EMPTY_LISTS_STRATEGY, strategies, self.schema.type_map)
         # No overlapping - safe to choose any subset of fields within the interface itself and any fragment
         return st.tuples(*(self.inline_fragment(type_) for type_ in items)).map(list)
 

test/test_corpus.py

@@ -1,7 +1,7 @@
 import json
 
 import pytest
-from hypothesis import HealthCheck, Phase, Verbosity, given, seed, settings
+from hypothesis import HealthCheck, Phase, Verbosity, given, settings
 from hypothesis import strategies as st
 
 from hypothesis_graphql import strategies as gql_st

test/test_queries.py

@@ -205,115 +205,156 @@ def test_no_surrogates(data, validate_operation):
     value.encode("utf8")
 
 
+ALIASES_INTERFACE_TWO_TYPES = """interface Conflict {
+  id: ID
+}
+
+type FloatModel implements Conflict {
+  id: ID,
+  query: Float!
+}
+
+type StringModel implements Conflict {
+  id: ID,
+  query: String!
+}
+
+type Query {
+  getData: Conflict
+}"""
+ALIASES_MULTIPLE_INTERFACE_OVERLAP = """interface Nullable {
+  value: Float
+}
+interface Another {
+  non_value: Float
+}
+interface NotNullable {
+  value: Float!
+}
+
+type First implements Nullable {
+  value: Float
+}
+
+type Second implements NotNullable & Another {
+  value: Float!
+  non_value: Float
+}
+
+union FirstOrSecond = First | Second
+
+type Query {
+  getData: FirstOrSecond!
+}"""
+ALIASES_INTERFACE_THREE_TYPES = """interface Conflict {
+  id: ID!
+}
+
+type First implements Conflict {
+  id: ID!
+  key: String
+}
+
+type Second implements Conflict {
+  id: ID!
+  key: String
+}
+
+type Third implements Conflict {
+  id: ID!
+  key: [String]
+}
+
+type Query {
+  getData: Conflict
+}"""
+ALIASES_INTERFACE_NESTED_TYPE = """interface Conflict {
+  keywords: [Keyword!]!
+}
+
+type First implements Conflict {
+  keywords: [Keyword!]!
+}
+
+type Keyword {
+  values(first: Int): String!
+}
+
+type Query {
+  getData(input: Int!): Conflict
+}"""
+ALIASES_UNION_RETURN_TYPE = """type FloatModel {
+  query: Float!
+}
+type StringModel {
+  query: String!
+}
+
+union Conflict = FloatModel | StringModel
+
+type Query {
+  getData: Conflict
+}"""
+ALIASES_ARGUMENT_ENUM = """interface Conflict {
+  query(arg: Arg): String!
+}
+
+type FirstModel implements Conflict {
+  query(arg: Arg): String!
+}
+
+type SecondModel implements Conflict {
+  query(arg: Arg): String!
+}
+
+enum Arg {
+  First
+  Second
+}
+
+type Query {
+  getConflict(arg: String!): Conflict!
+}"""
+ALIASES_ARGUMENT_STRING = """interface Conflict {
+  query(arg: String): String!
+}
+
+type FirstModel implements Conflict {
+  query(arg: String): String!
+}
+
+type SecondModel implements Conflict {
+  query(arg: String): String!
+}
+
+type Query {
+  getConflict(arg: String!): Conflict!
+}"""
+
+
 @pytest.mark.parametrize(
     "schema",
     (
-        """interface Conflict {
-          id: ID
-        }
-
-        type FloatModel implements Conflict {
-          id: ID,
-          query: Float!
-        }
-
-        type StringModel implements Conflict {
-          id: ID,
-          query: String!
-        }
-
-        type Query {
-          getData: Conflict
-        }""",
-        """interface Conflict {
-          id: ID!
-        }
-
-        type First implements Conflict {
-          id: ID!
-          key: String
-        }
-
-        type Second implements Conflict {
-          id: ID!
-          key: String
-        }
-
-        type Third implements Conflict {
-          id: ID!
-          key: [String]
-        }
-
-        type Query {
-          getData: Conflict
-        }""",
-        """interface Conflict {
-          keywords: [Keyword!]!
-        }
-
-        type First implements Conflict {
-          keywords: [Keyword!]!
-        }
-
-        type Keyword {
-          values(first: Int): String!
-        }
-
-        type Query {
-          getData(input: Int!): Conflict
-        }""",
-        """type FloatModel {
-          query: Float!
-        }
-        type StringModel {
-          query: String!
-        }
-
-        union Conflict = FloatModel | StringModel
-
-        type Query {
-          getData: Conflict
-        }""",
-        """interface Conflict {
-          query(arg: Arg): String!
-        }
-
-        type FirstModel implements Conflict {
-          query(arg: Arg): String!
-        }
-
-        type SecondModel implements Conflict {
-          query(arg: Arg): String!
-        }
-
-        enum Arg {
-          First
-          Second
-        }
-
-        type Query {
-          getConflict(arg: String!): Conflict!
-        }""",
-        """interface Conflict {
-          query(arg: String): String!
-        }
-
-        type FirstModel implements Conflict {
-          query(arg: String): String!
-        }
-
-        type SecondModel implements Conflict {
-          query(arg: String): String!
-        }
-
-        type Query {
-          getConflict(arg: String!): Conflict!
-        }""",
+        ALIASES_INTERFACE_TWO_TYPES,
+        ALIASES_INTERFACE_THREE_TYPES,
+        ALIASES_INTERFACE_NESTED_TYPE,
+        ALIASES_MULTIPLE_INTERFACE_OVERLAP,
+        ALIASES_UNION_RETURN_TYPE,
+        ALIASES_ARGUMENT_ENUM,
+        ALIASES_ARGUMENT_STRING,
+    ),
+    ids=(
+        "interface-two-types",
+        "interface-three-types",
+        "interface-nested-type",
+        "non-interface",
+        "union",
+        "argument-enum",
+        "argument-string",
     ),
-    ids=("interface", "interface-multiple-types", "interface-sub-type", "union", "arguments-enum", "arguments-string"),
 )
 @given(data=st.data())
-def test_conflicting_field_types(data, validate_operation, schema):
+def test_aliases(data, validate_operation, schema):
     # See GH-49, GH-57
     # When Query contain types on the same level that have fields with the same name but with different types
     query = data.draw(gql_st.queries(schema))