Skip to content

Commit 74a0270

Browse files
committed
Added missing linter
1 parent f0a7bf4 commit 74a0270

4 files changed

Lines changed: 12 additions & 2 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ proto:
2424
.PHONY: lint
2525
lint:
2626
@go-cleanarch
27+
@./scripts/lint.sh common
2728
@./scripts/lint.sh trainer
2829
@./scripts/lint.sh trainings
2930
@./scripts/lint.sh users

internal/common/client/grpc.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ func grpcDialOpts(grpcAddr string) ([]grpc.DialOption, error) {
7070
return nil, errors.Wrap(err, "cannot load root CA cert")
7171
}
7272
creds := credentials.NewTLS(&tls.Config{
73-
RootCAs: systemRoots,
73+
RootCAs: systemRoots,
74+
MinVersion: tls.VersionTLS12,
7475
})
7576

7677
return []grpc.DialOption{

internal/common/server/http.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func RunHTTPServerOnAddr(addr string, createHandler func(router chi.Router) http
3131

3232
logrus.Info("Starting HTTP server")
3333

34-
http.ListenAndServe(addr, rootRouter)
34+
_ = http.ListenAndServe(addr, rootRouter)
3535
}
3636

3737
func setMiddlewares(router *chi.Mux) {

internal/common/tests/clients.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ func (c TrainerHTTPClient) MakeHourAvailable(t *testing.T, hour time.Time) int {
4949
Hours: []time.Time{hour},
5050
})
5151
require.NoError(t, err)
52+
require.NoError(t, response.Body.Close())
53+
5254
return response.StatusCode
5355
}
5456

@@ -57,6 +59,8 @@ func (c TrainerHTTPClient) MakeHourUnavailable(t *testing.T, hour time.Time) {
5759
Hours: []time.Time{hour},
5860
})
5961
require.NoError(t, err)
62+
require.NoError(t, response.Body.Close())
63+
6064
require.Equal(t, http.StatusNoContent, response.StatusCode)
6165
}
6266

@@ -113,6 +117,8 @@ func (c TrainingsHTTPClient) CreateTrainingShouldFail(t *testing.T, note string,
113117
Time: hour,
114118
})
115119
require.NoError(t, err)
120+
require.NoError(t, response.Body.Close())
121+
116122
require.Equal(t, http.StatusInternalServerError, response.StatusCode)
117123
}
118124

@@ -127,6 +133,8 @@ func (c TrainingsHTTPClient) GetTrainings(t *testing.T) trainings.Trainings {
127133
func (c TrainingsHTTPClient) CancelTraining(t *testing.T, trainingUUID string, expectedStatusCode int) {
128134
response, err := c.client.CancelTraining(context.Background(), trainingUUID)
129135
require.NoError(t, err)
136+
require.NoError(t, response.Body.Close())
137+
130138
require.Equal(t, expectedStatusCode, response.StatusCode)
131139
}
132140

0 commit comments

Comments
 (0)