Skip to content

Commit 02744a5

Browse files
majdmellanoxgregkh
authored andcommitted
net/mlx4_core: Fix VF overwrite of module param which disables DMFS on new probed PFs
[ Upstream commit 95f1ba9a24af9769f6e20dfe9a77c863f253f311 ] In the VF driver, module parameter mlx4_log_num_mgm_entry_size was mistakenly overwritten -- and in a manner which overrode the device-managed flow steering option encoded in the parameter. log_num_mgm_entry_size is a global module parameter which affects all ConnectX-3 PFs installed on that host. If a VF changes log_num_mgm_entry_size, this will affect all PFs which are probed subsequent to the change (by disabling DMFS for those PFs). Fixes: 3c439b5 ("mlx4_core: Allow choosing flow steering mode") Signed-off-by: Majd Dibbiny <majd@mellanox.com> Reviewed-by: Jack Morgenstein <jackm@dev.mellanox.co.il> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7bf94b9 commit 02744a5

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

  • drivers/net/ethernet/mellanox/mlx4

drivers/net/ethernet/mellanox/mlx4/main.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -791,8 +791,6 @@ static int mlx4_slave_cap(struct mlx4_dev *dev)
791791
return -ENOSYS;
792792
}
793793

794-
mlx4_log_num_mgm_entry_size = hca_param.log_mc_entry_sz;
795-
796794
dev->caps.hca_core_clock = hca_param.hca_core_clock;
797795

798796
memset(&dev_cap, 0, sizeof(dev_cap));

0 commit comments

Comments
 (0)