Skip to content

Commit 068d12e

Browse files
vireshkAlex Shi
authored andcommitted
PM / OPP: Rename OPP nodes as opp@<opp-hz>
It would be better to name OPP nodes as opp@<opp-hz> as that will ensure that multiple DT nodes don't contain the same frequency. Of course we expect the writer to name the node with its opp-hz frequency and not any other frequency. And that will let the compile error out if multiple nodes are using the same opp-hz frequency. Suggested-by: Stephen Boyd <sboyd@codeaurora.org> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> (cherry picked from commit 754dcf35f34698661801ae1d391efa02affe83a7) Signed-off-by: Alex Shi <alex.shi@linaro.org>
1 parent 2e86d07 commit 068d12e

1 file changed

Lines changed: 19 additions & 19 deletions

File tree

  • Documentation/devicetree/bindings/opp

Documentation/devicetree/bindings/opp/opp.txt

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -177,20 +177,20 @@ Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together.
177177
compatible = "operating-points-v2";
178178
opp-shared;
179179

180-
opp00 {
180+
opp@1000000000 {
181181
opp-hz = /bits/ 64 <1000000000>;
182182
opp-microvolt = <970000 975000 985000>;
183183
opp-microamp = <70000>;
184184
clock-latency-ns = <300000>;
185185
opp-suspend;
186186
};
187-
opp01 {
187+
opp@1100000000 {
188188
opp-hz = /bits/ 64 <1100000000>;
189189
opp-microvolt = <980000 1000000 1010000>;
190190
opp-microamp = <80000>;
191191
clock-latency-ns = <310000>;
192192
};
193-
opp02 {
193+
opp@1200000000 {
194194
opp-hz = /bits/ 64 <1200000000>;
195195
opp-microvolt = <1025000>;
196196
clock-latency-ns = <290000>;
@@ -256,20 +256,20 @@ independently.
256256
* independently.
257257
*/
258258

259-
opp00 {
259+
opp@1000000000 {
260260
opp-hz = /bits/ 64 <1000000000>;
261261
opp-microvolt = <970000 975000 985000>;
262262
opp-microamp = <70000>;
263263
clock-latency-ns = <300000>;
264264
opp-suspend;
265265
};
266-
opp01 {
266+
opp@1100000000 {
267267
opp-hz = /bits/ 64 <1100000000>;
268268
opp-microvolt = <980000 1000000 1010000>;
269269
opp-microamp = <80000>;
270270
clock-latency-ns = <310000>;
271271
};
272-
opp02 {
272+
opp@1200000000 {
273273
opp-hz = /bits/ 64 <1200000000>;
274274
opp-microvolt = <1025000>;
275275
opp-microamp = <90000;
@@ -332,20 +332,20 @@ DVFS state together.
332332
compatible = "operating-points-v2";
333333
opp-shared;
334334

335-
opp00 {
335+
opp@1000000000 {
336336
opp-hz = /bits/ 64 <1000000000>;
337337
opp-microvolt = <970000 975000 985000>;
338338
opp-microamp = <70000>;
339339
clock-latency-ns = <300000>;
340340
opp-suspend;
341341
};
342-
opp01 {
342+
opp@1100000000 {
343343
opp-hz = /bits/ 64 <1100000000>;
344344
opp-microvolt = <980000 1000000 1010000>;
345345
opp-microamp = <80000>;
346346
clock-latency-ns = <310000>;
347347
};
348-
opp02 {
348+
opp@1200000000 {
349349
opp-hz = /bits/ 64 <1200000000>;
350350
opp-microvolt = <1025000>;
351351
opp-microamp = <90000>;
@@ -358,20 +358,20 @@ DVFS state together.
358358
compatible = "operating-points-v2";
359359
opp-shared;
360360

361-
opp10 {
361+
opp@1300000000 {
362362
opp-hz = /bits/ 64 <1300000000>;
363363
opp-microvolt = <1045000 1050000 1055000>;
364364
opp-microamp = <95000>;
365365
clock-latency-ns = <400000>;
366366
opp-suspend;
367367
};
368-
opp11 {
368+
opp@1400000000 {
369369
opp-hz = /bits/ 64 <1400000000>;
370370
opp-microvolt = <1075000>;
371371
opp-microamp = <100000>;
372372
clock-latency-ns = <400000>;
373373
};
374-
opp12 {
374+
opp@1500000000 {
375375
opp-hz = /bits/ 64 <1500000000>;
376376
opp-microvolt = <1010000 1100000 1110000>;
377377
opp-microamp = <95000>;
@@ -398,7 +398,7 @@ Example 4: Handling multiple regulators
398398
compatible = "operating-points-v2";
399399
opp-shared;
400400

401-
opp00 {
401+
opp@1000000000 {
402402
opp-hz = /bits/ 64 <1000000000>;
403403
opp-microvolt = <970000>, /* Supply 0 */
404404
<960000>, /* Supply 1 */
@@ -411,7 +411,7 @@ Example 4: Handling multiple regulators
411411

412412
/* OR */
413413

414-
opp00 {
414+
opp@1000000000 {
415415
opp-hz = /bits/ 64 <1000000000>;
416416
opp-microvolt = <970000 975000 985000>, /* Supply 0 */
417417
<960000 965000 975000>, /* Supply 1 */
@@ -424,7 +424,7 @@ Example 4: Handling multiple regulators
424424

425425
/* OR */
426426

427-
opp00 {
427+
opp@1000000000 {
428428
opp-hz = /bits/ 64 <1000000000>;
429429
opp-microvolt = <970000 975000 985000>, /* Supply 0 */
430430
<960000 965000 975000>, /* Supply 1 */
@@ -456,7 +456,7 @@ Example 5: opp-supported-hw
456456
status = "okay";
457457
opp-shared;
458458

459-
opp00 {
459+
opp@600000000 {
460460
/*
461461
* Supports all substrate and process versions for 0xF
462462
* cuts, i.e. only first four cuts.
@@ -467,7 +467,7 @@ Example 5: opp-supported-hw
467467
...
468468
};
469469

470-
opp01 {
470+
opp@800000000 {
471471
/*
472472
* Supports:
473473
* - cuts: only one, 6th cut (represented by 6th bit).
@@ -499,15 +499,15 @@ Example 6: opp-microvolt-<name>, opp-microamp-<name>:
499499
compatible = "operating-points-v2";
500500
opp-shared;
501501

502-
opp00 {
502+
opp@1000000000 {
503503
opp-hz = /bits/ 64 <1000000000>;
504504
opp-microvolt-slow = <900000 915000 925000>;
505505
opp-microvolt-fast = <970000 975000 985000>;
506506
opp-microamp-slow = <70000>;
507507
opp-microamp-fast = <71000>;
508508
};
509509

510-
opp01 {
510+
opp@1200000000 {
511511
opp-hz = /bits/ 64 <1200000000>;
512512
opp-microvolt-slow = <900000 915000 925000>, /* Supply vcc0 */
513513
<910000 925000 935000>; /* Supply vcc1 */

0 commit comments

Comments
 (0)