Skip to content

Commit 0e075f2

Browse files
Murray McAllistergregkh
authored andcommitted
drm/vmwgfx: avoid calling vzalloc with a 0 size in vmw_get_cap_3d_ioctl()
commit 63774069d9527a1aeaa4aa20e929ef5e8e9ecc38 upstream. In vmw_get_cap_3d_ioctl(), a user can supply 0 for a size that is used in vzalloc(). This eventually calls dump_stack() (in warn_alloc()), which can leak useful addresses to dmesg. Add check to avoid a size of 0. Signed-off-by: Murray McAllister <murray.mcallister@insomniasec.com> Reviewed-by: Sinclair Yeh <syeh@vmware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent b266294 commit 0e075f2

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ int vmw_get_cap_3d_ioctl(struct drm_device *dev, void *data,
186186
bool gb_objects = !!(dev_priv->capabilities & SVGA_CAP_GBOBJECTS);
187187
struct vmw_fpriv *vmw_fp = vmw_fpriv(file_priv);
188188

189-
if (unlikely(arg->pad64 != 0)) {
189+
if (unlikely(arg->pad64 != 0 || arg->max_size == 0)) {
190190
DRM_ERROR("Illegal GET_3D_CAP argument.\n");
191191
return -EINVAL;
192192
}

0 commit comments

Comments
 (0)