Skip to content

Commit 1df403a

Browse files
l1kgregkh
authored andcommitted
serial: omap: Fix EFR write on RTS deassertion
commit 2a71de2f7366fb1aec632116d0549ec56d6a3940 upstream. Commit 348f9bb ("serial: omap: Fix RTS handling") sought to enable auto RTS upon manual RTS assertion and disable it on deassertion. However it seems the latter was done incorrectly, it clears all bits in the Extended Features Register *except* auto RTS. Fixes: 348f9bb ("serial: omap: Fix RTS handling") Cc: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Lukas Wunner <lukas@wunner.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a9100b6 commit 1df403a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/serial/omap-serial.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ static void serial_omap_set_mctrl(struct uart_port *port, unsigned int mctrl)
693693
if ((mctrl & TIOCM_RTS) && (port->status & UPSTAT_AUTORTS))
694694
up->efr |= UART_EFR_RTS;
695695
else
696-
up->efr &= UART_EFR_RTS;
696+
up->efr &= ~UART_EFR_RTS;
697697
serial_out(up, UART_EFR, up->efr);
698698
serial_out(up, UART_LCR, lcr);
699699

0 commit comments

Comments
 (0)