Skip to content

Commit 23c7f01

Browse files
cappsulegregkh
authored andcommitted
virtio_console: fix a crash in config_work_handler
[ Upstream commit 8379cadf71c3ee8173a1c6fc1ea7762a9638c047 ] Using control_work instead of config_work as the 3rd argument to container_of results in an invalid portdev pointer. Indeed, the work structure is initialized as below: INIT_WORK(&portdev->config_work, &config_work_handler); It leads to a crash when portdev->vdev is dereferenced later. This bug is triggered when the guest uses a virtio-console without multiport feature and receives a config_changed virtio interrupt. Signed-off-by: G. Campana <gcampana@quarkslab.com> Reviewed-by: Amit Shah <amit.shah@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6e1116a commit 23c7f01

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/char/virtio_console.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1864,7 +1864,7 @@ static void config_work_handler(struct work_struct *work)
18641864
{
18651865
struct ports_device *portdev;
18661866

1867-
portdev = container_of(work, struct ports_device, control_work);
1867+
portdev = container_of(work, struct ports_device, config_work);
18681868
if (!use_multiport(portdev)) {
18691869
struct virtio_device *vdev;
18701870
struct port *port;

0 commit comments

Comments
 (0)