bt8xx: fix memory leak

sudipm-mukherjee · gregkh · commit 298455f466cb · 2017-11-08T10:06:30.000+01:00
[ Upstream commit 6792eb0cf9310ec240b7e7c9bfa86dff4c758c68 ]

If dvb_attach() fails then we were just printing an error message and
exiting but the memory allocated to state was not released.

Signed-off-by: Sudip Mukherjee &lt;sudip.mukherjee@codethink.co.uk&gt;
Signed-off-by: Hans Verkuil &lt;hans.verkuil@cisco.com&gt;
Signed-off-by: Mauro Carvalho Chehab &lt;mchehab@s-opensource.com&gt;
Signed-off-by: Sasha Levin &lt;alexander.levin@verizon.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/media/pci/bt8xx/dvb-bt8xx.c b/drivers/media/pci/bt8xx/dvb-bt8xx.c
@@ -680,6 +680,7 @@ static void frontend_init(struct dvb_bt8xx_card *card, u32 type)
 		/*	DST is not a frontend, attaching the ASIC	*/
 		if (dvb_attach(dst_attach, state, &card->dvb_adapter) == NULL) {
 			pr_err("%s: Could not find a Twinhan DST\n", __func__);
+			kfree(state);
 			break;
 		}
 		/*	Attach other DST peripherals if any		*/

Original file line number	Diff line number	Diff line change
`@@ -680,6 +680,7 @@ static void frontend_init(struct dvb_bt8xx_card *card, u32 type)`
`680`	`680`	`/* DST is not a frontend, attaching the ASIC */`
`681`	`681`	`if (dvb_attach(dst_attach, state, &card->dvb_adapter) == NULL) {`
`682`	`682`	`pr_err("%s: Could not find a Twinhan DST\n", __func__);`
	`683`	`+ kfree(state);`
`683`	`684`	`break;`
`684`	`685`	`}`
`685`	`686`	`/* Attach other DST peripherals if any */`