Skip to content

Commit 29b202e

Browse files
paulburtongregkh
authored andcommitted
MIPS: math-emu: Remove pr_err() calls from fpu_emu()
commit ca8eb05b5f332a9e1ab3e2ece498d49f4d683470 upstream. The FPU emulator includes 2 calls to pr_err() which are triggered by invalid instruction encodings for MIPSr6 cmp.cond.fmt instructions. These cases are not kernel errors, merely invalid instructions which are already handled by delivering a SIGILL which will provide notification that something failed in cases where that makes sense. In cases where that SIGILL is somewhat expected & being handled, for example when crashme happens to generate one of the affected bad encodings, the message is printed with no useful context about what triggered it & spams the kernel log for no good reason. Remove the pr_err() calls to make crashme run silently & treat the bad encodings the same way we do others, with a SIGILL & no further kernel log output. Signed-off-by: Paul Burton <paul.burton@imgtec.com> Fixes: f8c3c67 ("MIPS: math-emu: Add support for the CMP.condn.fmt R6 instruction") Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/17253/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2fff3c5 commit 29b202e

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

arch/mips/math-emu/cp1emu.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2360,7 +2360,6 @@ static int fpu_emu(struct pt_regs *xcp, struct mips_fpu_struct *ctx,
23602360
break;
23612361
default:
23622362
/* Reserved R6 ops */
2363-
pr_err("Reserved MIPS R6 CMP.condn.S operation\n");
23642363
return SIGILL;
23652364
}
23662365
}
@@ -2434,7 +2433,6 @@ static int fpu_emu(struct pt_regs *xcp, struct mips_fpu_struct *ctx,
24342433
break;
24352434
default:
24362435
/* Reserved R6 ops */
2437-
pr_err("Reserved MIPS R6 CMP.condn.D operation\n");
24382436
return SIGILL;
24392437
}
24402438
}

0 commit comments

Comments
 (0)