Skip to content

Commit 2bb04f1

Browse files
Roger Quadrosgregkh
authored andcommitted
extcon: palmas: Check the parent instance to prevent the NULL
[ Upstream commit 9fe172b9be532acc23e35ba693700383ab775e66 ] extcon-palmas must be child of palmas and expects parent's drvdata to be valid. Check for non NULL parent drvdata and fail if it is NULL. Not doing so will result in a NULL pointer dereference later in the probe() parent drvdata is NULL (e.g. misplaced extcon-palmas node in device tree). Signed-off-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8d9142f commit 2bb04f1

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/extcon/extcon-palmas.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,11 @@ static int palmas_usb_probe(struct platform_device *pdev)
190190
struct palmas_usb *palmas_usb;
191191
int status;
192192

193+
if (!palmas) {
194+
dev_err(&pdev->dev, "failed to get valid parent\n");
195+
return -EINVAL;
196+
}
197+
193198
palmas_usb = devm_kzalloc(&pdev->dev, sizeof(*palmas_usb), GFP_KERNEL);
194199
if (!palmas_usb)
195200
return -ENOMEM;

0 commit comments

Comments
 (0)