Skip to content

Commit 30f0761

Browse files
sudipm-mukherjeegregkh
authored andcommitted
USB: mos7720: delete parport
commit dcb21ad4385731b7fc3ef39d255685f2f63c8c5d upstream. parport subsystem has introduced parport_del_port() to delete a port when it is going away. Without parport_del_port() the registered port will not be unregistered. To reproduce and verify the error: Command to be used is : ls /sys/bus/parport/devices 1) without the device attached there is no output as there is no registered parport. 2) Attach the device, and the command will show "parport0". 3) Remove the device and the command still shows "parport0". 4) Attach the device again and we get "parport1". With the patch applied: 1) without the device attached there is no output as there is no registered parport. 2) Attach the device, and the command will show "parport0". 3) Remove the device and there is no output as "parport0" is now removed. 4) Attach device again to get "parport0" again. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a20257e commit 30f0761

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/usb/serial/mos7720.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2007,6 +2007,7 @@ static void mos7720_release(struct usb_serial *serial)
20072007
urblist_entry)
20082008
usb_unlink_urb(urbtrack->urb);
20092009
spin_unlock_irqrestore(&mos_parport->listlock, flags);
2010+
parport_del_port(mos_parport->pp);
20102011

20112012
kref_put(&mos_parport->ref_count, destroy_mos_parport);
20122013
}

0 commit comments

Comments
 (0)