Skip to content

Commit 32b850a

Browse files
Burak Okgregkh
authored andcommitted
scsi: snic: Return error code on memory allocation failure
[ Upstream commit 0371adcdaca92912baaa3256ed13e058a016e62d ] If a call to mempool_create_slab_pool() in snic_probe() returns NULL, return -ENOMEM to indicate failure. mempool_creat_slab_pool() only fails if it cannot allocate memory. https://bugzilla.kernel.org/show_bug.cgi?id=189061 Reported-by: bianpan2010@ruc.edu.cn Signed-off-by: Burak Ok <burak-kernel@bur0k.de> Signed-off-by: Andreas Schaertl <andreas.schaertl@fau.de> Acked-by: Narsimhulu Musini <nmusini@cisco.com> Reviewed-by: Ewan D. Milne <emilne@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 27eb77b commit 32b850a

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/scsi/snic/snic_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -584,6 +584,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
584584
if (!pool) {
585585
SNIC_HOST_ERR(shost, "dflt sgl pool creation failed\n");
586586

587+
ret = -ENOMEM;
587588
goto err_free_res;
588589
}
589590

@@ -594,6 +595,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
594595
if (!pool) {
595596
SNIC_HOST_ERR(shost, "max sgl pool creation failed\n");
596597

598+
ret = -ENOMEM;
597599
goto err_free_dflt_sgl_pool;
598600
}
599601

@@ -604,6 +606,7 @@ snic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
604606
if (!pool) {
605607
SNIC_HOST_ERR(shost, "snic tmreq info pool creation failed.\n");
606608

609+
ret = -ENOMEM;
607610
goto err_free_max_sgl_pool;
608611
}
609612

0 commit comments

Comments
 (0)