Skip to content

Commit 3865040

Browse files
Zheng Ligregkh
authored andcommitted
ipv6: Should use consistent conditional judgement for ip6 fragment between __ip6_append_data and ip6_finish_output
[ Upstream commit e4c5e13aa45c23692e4acf56f0b3533f328199b2 ] There is an inconsistent conditional judgement between __ip6_append_data and ip6_finish_output functions, the variable length in __ip6_append_data just include the length of application's payload and udp6 header, don't include the length of ipv6 header, but in ip6_finish_output use (skb->len > ip6_skb_dst_mtu(skb)) as judgement, and skb->len include the length of ipv6 header. That causes some particular application's udp6 payloads whose length are between (MTU - IPv6 Header) and MTU were fragmented by ip6_fragment even though the rst->dev support UFO feature. Add the length of ipv6 header to length in __ip6_append_data to keep consistent conditional judgement as ip6_finish_output for ip6 fragment. Signed-off-by: Zheng Li <james.z.li@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ed3e4a4 commit 3865040

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/ipv6/ip6_output.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1361,7 +1361,7 @@ static int __ip6_append_data(struct sock *sk,
13611361
*/
13621362

13631363
cork->length += length;
1364-
if (((length > mtu) ||
1364+
if ((((length + fragheaderlen) > mtu) ||
13651365
(skb && skb_is_gso(skb))) &&
13661366
(sk->sk_protocol == IPPROTO_UDP) &&
13671367
(rt->dst.dev->features & NETIF_F_UFO) &&

0 commit comments

Comments
 (0)