Skip to content

Commit 397488e

Browse files
vittyvkgregkh
authored andcommitted
Tools: hv: kvp: ensure kvp device fd is closed on exec
commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 upstream. KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2a60bb6 commit 397488e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/hv/hv_kvp_daemon.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1433,7 +1433,7 @@ int main(int argc, char *argv[])
14331433
openlog("KVP", 0, LOG_USER);
14341434
syslog(LOG_INFO, "KVP starting; pid is:%d", getpid());
14351435

1436-
kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR);
1436+
kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC);
14371437

14381438
if (kvp_fd < 0) {
14391439
syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",

0 commit comments

Comments
 (0)