Skip to content

Commit 3cc247f

Browse files
Jaegeuk Kimpundiramit
authored andcommitted
f2fs: free meta pages if sanity check for ckpt is failed
commit a2125ff7dd1ed3a2a53cdc1f8f9c9cec9cfaa7ab upstream. This fixes missing freeing meta pages in the error case. Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 5a28184 commit 3cc247f

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

fs/f2fs/checkpoint.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,7 @@ int get_valid_checkpoint(struct f2fs_sb_info *sbi)
768768

769769
/* Sanity checking of checkpoint */
770770
if (sanity_check_ckpt(sbi))
771-
goto fail_no_cp;
771+
goto free_fail_no_cp;
772772

773773
if (cur_page == cp1)
774774
sbi->cur_cp_pack = 1;
@@ -796,6 +796,9 @@ int get_valid_checkpoint(struct f2fs_sb_info *sbi)
796796
f2fs_put_page(cp2, 1);
797797
return 0;
798798

799+
free_fail_no_cp:
800+
f2fs_put_page(cp1, 1);
801+
f2fs_put_page(cp2, 1);
799802
fail_no_cp:
800803
kfree(sbi->ckpt);
801804
return -EINVAL;

0 commit comments

Comments
 (0)