Skip to content

Commit 401231d

Browse files
committed
Revert "tty: goldfish: Fix a parameter of a call to free_irq"
This reverts commit 01b3db2 which is commit 1a5c2d1de7d35f5eb9793266237903348989502b upstream. Ben writes: This fixes a bug introduced in 4.6 by commit 465893e18878 "tty: goldfish: support platform_device with id -1". For earlier kernel versions, it *introduces* a bug. So let's drop it. Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
1 parent cdbbea7 commit 401231d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/goldfish.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static int goldfish_tty_probe(struct platform_device *pdev)
293293
return 0;
294294

295295
err_tty_register_device_failed:
296-
free_irq(irq, qtty);
296+
free_irq(irq, pdev);
297297
err_request_irq_failed:
298298
goldfish_tty_current_line_count--;
299299
if (goldfish_tty_current_line_count == 0)

0 commit comments

Comments
 (0)