Skip to content

Commit 435cc43

Browse files
James Hogangregkh
James Hogan
authored and
gregkh
committed
metag/usercopy: Add missing fixups
commit b884a190afcecdbef34ca508ea5ee88bb7c77861 upstream. The rapf copy loops in the Meta usercopy code is missing some extable entries for HTP cores with unaligned access checking enabled, where faults occur on the instruction immediately after the faulting access. Add the fixup labels and extable entries for these cases so that corner case user copy failures don't cause kernel crashes. Fixes: 373cd78 ("metag: Memory handling") Signed-off-by: James Hogan <james.hogan@imgtec.com> Cc: linux-metag@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3040ecd commit 435cc43

1 file changed

Lines changed: 48 additions & 24 deletions

File tree

‎arch/metag/lib/usercopy.c‎

Lines changed: 48 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -259,27 +259,31 @@
259259
"MGETL D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
260260
"22:\n" \
261261
"MSETL [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
262-
"SUB %3, %3, #32\n" \
263262
"23:\n" \
264-
"MGETL D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
263+
"SUB %3, %3, #32\n" \
265264
"24:\n" \
265+
"MGETL D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
266+
"25:\n" \
266267
"MSETL [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
268+
"26:\n" \
267269
"SUB %3, %3, #32\n" \
268270
"DCACHE [%1+#-64], D0Ar6\n" \
269271
"BR $Lloop"id"\n" \
270272
\
271273
"MOV RAPF, %1\n" \
272-
"25:\n" \
274+
"27:\n" \
273275
"MGETL D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
274-
"26:\n" \
276+
"28:\n" \
275277
"MSETL [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
278+
"29:\n" \
276279
"SUB %3, %3, #32\n" \
277-
"27:\n" \
280+
"30:\n" \
278281
"MGETL D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
279-
"28:\n" \
282+
"31:\n" \
280283
"MSETL [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
284+
"32:\n" \
281285
"SUB %0, %0, #8\n" \
282-
"29:\n" \
286+
"33:\n" \
283287
"SETL [%0++], D0.7, D1.7\n" \
284288
"SUB %3, %3, #32\n" \
285289
"1:" \
@@ -311,7 +315,11 @@
311315
" .long 26b,3b\n" \
312316
" .long 27b,3b\n" \
313317
" .long 28b,3b\n" \
314-
" .long 29b,4b\n" \
318+
" .long 29b,3b\n" \
319+
" .long 30b,3b\n" \
320+
" .long 31b,3b\n" \
321+
" .long 32b,3b\n" \
322+
" .long 33b,4b\n" \
315323
" .previous\n" \
316324
: "=r" (to), "=r" (from), "=r" (ret), "=d" (n) \
317325
: "0" (to), "1" (from), "2" (ret), "3" (n) \
@@ -402,47 +410,55 @@
402410
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
403411
"22:\n" \
404412
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
405-
"SUB %3, %3, #16\n" \
406413
"23:\n" \
407-
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
408-
"24:\n" \
409-
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
410414
"SUB %3, %3, #16\n" \
411-
"25:\n" \
415+
"24:\n" \
412416
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
413-
"26:\n" \
417+
"25:\n" \
414418
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
419+
"26:\n" \
415420
"SUB %3, %3, #16\n" \
416421
"27:\n" \
417422
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
418423
"28:\n" \
419424
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
425+
"29:\n" \
426+
"SUB %3, %3, #16\n" \
427+
"30:\n" \
428+
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
429+
"31:\n" \
430+
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
431+
"32:\n" \
420432
"SUB %3, %3, #16\n" \
421433
"DCACHE [%1+#-64], D0Ar6\n" \
422434
"BR $Lloop"id"\n" \
423435
\
424436
"MOV RAPF, %1\n" \
425-
"29:\n" \
437+
"33:\n" \
426438
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
427-
"30:\n" \
439+
"34:\n" \
428440
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
441+
"35:\n" \
429442
"SUB %3, %3, #16\n" \
430-
"31:\n" \
443+
"36:\n" \
431444
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
432-
"32:\n" \
445+
"37:\n" \
433446
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
447+
"38:\n" \
434448
"SUB %3, %3, #16\n" \
435-
"33:\n" \
449+
"39:\n" \
436450
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
437-
"34:\n" \
451+
"40:\n" \
438452
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
453+
"41:\n" \
439454
"SUB %3, %3, #16\n" \
440-
"35:\n" \
455+
"42:\n" \
441456
"MGETD D0FrT, D0.5, D0.6, D0.7, [%1++]\n" \
442-
"36:\n" \
457+
"43:\n" \
443458
"MSETD [%0++], D0FrT, D0.5, D0.6, D0.7\n" \
459+
"44:\n" \
444460
"SUB %0, %0, #4\n" \
445-
"37:\n" \
461+
"45:\n" \
446462
"SETD [%0++], D0.7\n" \
447463
"SUB %3, %3, #16\n" \
448464
"1:" \
@@ -482,7 +498,15 @@
482498
" .long 34b,3b\n" \
483499
" .long 35b,3b\n" \
484500
" .long 36b,3b\n" \
485-
" .long 37b,4b\n" \
501+
" .long 37b,3b\n" \
502+
" .long 38b,3b\n" \
503+
" .long 39b,3b\n" \
504+
" .long 40b,3b\n" \
505+
" .long 41b,3b\n" \
506+
" .long 42b,3b\n" \
507+
" .long 43b,3b\n" \
508+
" .long 44b,3b\n" \
509+
" .long 45b,4b\n" \
486510
" .previous\n" \
487511
: "=r" (to), "=r" (from), "=r" (ret), "=d" (n) \
488512
: "0" (to), "1" (from), "2" (ret), "3" (n) \

0 commit comments

Comments
 (0)