Skip to content

Commit 43cf90f

Browse files
keesgregkh
authored andcommitted
arm64: move ELF_ET_DYN_BASE to 4GB / 4MB
commit 02445990a96e60a67526510d8b00f7e3d14101c3 upstream. Now that explicitly executed loaders are loaded in the mmap region, we have more freedom to decide where we position PIE binaries in the address space to avoid possible collisions with mmap or stack regions. For 64-bit, align to 4GB to allow runtimes to use the entire 32-bit address space for 32-bit pointers. On 32-bit use 4MB, to match ARM. This could be 0x8000, the standard ET_EXEC load address, but that is needlessly close to the NULL address, and anyone running arm compat PIE will have an MMU, so the tight mapping is not needed. Link: http://lkml.kernel.org/r/1498251600-132458-4-git-send-email-keescook@chromium.org Signed-off-by: Kees Cook <keescook@chromium.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d2471b5 commit 43cf90f

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

  • arch/arm64/include/asm

arch/arm64/include/asm/elf.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,12 +120,11 @@ typedef struct user_fpsimd_state elf_fpregset_t;
120120
#define ELF_EXEC_PAGESIZE PAGE_SIZE
121121

122122
/*
123-
* This is the location that an ET_DYN program is loaded if exec'ed. Typical
124-
* use of this is to invoke "./ld.so someprog" to test out a new version of
125-
* the loader. We need to make sure that it is out of the way of the program
126-
* that it will "exec", and that there is sufficient room for the brk.
123+
* This is the base location for PIE (ET_DYN with INTERP) loads. On
124+
* 64-bit, this is raised to 4GB to leave the entire 32-bit address
125+
* space open for things that want to use the area for 32-bit pointers.
127126
*/
128-
#define ELF_ET_DYN_BASE (2 * TASK_SIZE_64 / 3)
127+
#define ELF_ET_DYN_BASE 0x100000000UL
129128

130129
/*
131130
* When the program starts, a1 contains a pointer to a function to be
@@ -165,7 +164,8 @@ extern int arch_setup_additional_pages(struct linux_binprm *bprm,
165164

166165
#ifdef CONFIG_COMPAT
167166

168-
#define COMPAT_ELF_ET_DYN_BASE (2 * TASK_SIZE_32 / 3)
167+
/* PIE load location for compat arm. Must match ARM ELF_ET_DYN_BASE. */
168+
#define COMPAT_ELF_ET_DYN_BASE 0x000400000UL
169169

170170
/* AArch32 registers. */
171171
#define COMPAT_ELF_NGREG 18

0 commit comments

Comments
 (0)