Skip to content

Commit 46cb48d

Browse files
acgzxrkhuangtao
authored andcommitted
ASoC: rk3308_codec: add a bit of delay during enable DAC
The suggestion is from verndor, we should add a bit of delay in key steps until the reference voltages are stable, otherwise, the output of voltage maybe too low. @HPMIX -6dB + LINEOUT -6dB: normal Vpp: ~450mV abnormal Vpp: ~100mV Change-Id: I463d308b809b2c5e74e3bd37573bcbbd624df72e Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
1 parent f48d457 commit 46cb48d

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

sound/soc/codecs/rk3308_codec.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,9 @@ static int rk3308_codec_dac_enable(struct rk3308_codec_priv *rk3308)
761761
RK3308_DAC_BUF_REF_L_EN |
762762
RK3308_DAC_BUF_REF_R_EN);
763763

764+
/* Waiting the stable reference voltage */
765+
udelay(10);
766+
764767
if (rk3308->dac_output == DAC_HPOUT ||
765768
rk3308->dac_output == DAC_LINEOUT_HPOUT) {
766769
/* Step 03 */
@@ -778,6 +781,9 @@ static int rk3308_codec_dac_enable(struct rk3308_codec_priv *rk3308)
778781
RK3308_DAC_L_HPMIX_EN |
779782
RK3308_DAC_R_HPMIX_EN);
780783

784+
/* Waiting the stable HPMIX */
785+
udelay(10);
786+
781787
/* Step 05 */
782788
regmap_update_bits(rk3308->regmap, RK3308_DAC_ANA_CON13,
783789
RK3308_DAC_L_HPMIX_WORK |

0 commit comments

Comments
 (0)