Skip to content

Commit 4ac60b2

Browse files
Brendan McGrathgregkh
authored andcommitted
HID: i2c-hid: Add sleep between POWER ON and RESET
[ Upstream commit a89af4abdf9b353cdd6f61afc0eaaac403304873 ] Support for the Asus Touchpad was recently added. It turns out this device can fail initialisation (and become unusable) when the RESET command is sent too soon after the POWER ON command. Unfortunately the i2c-hid specification does not specify the need for a delay between these two commands. But it was discovered the Windows driver has a 1ms delay. As a result, this patch modifies the i2c-hid module to add a sleep inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms. See larixer/hid-asus-dkms#24 for further details. Signed-off-by: Brendan McGrath <redmcg@redmandi.dyndns.org> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 70f4100 commit 4ac60b2

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

drivers/hid/i2c-hid/i2c-hid.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,15 @@ static int i2c_hid_hwreset(struct i2c_client *client)
364364
if (ret)
365365
return ret;
366366

367+
/*
368+
* The HID over I2C specification states that if a DEVICE needs time
369+
* after the PWR_ON request, it should utilise CLOCK stretching.
370+
* However, it has been observered that the Windows driver provides a
371+
* 1ms sleep between the PWR_ON and RESET requests and that some devices
372+
* rely on this.
373+
*/
374+
usleep_range(1000, 5000);
375+
367376
i2c_hid_dbg(ihid, "resetting...\n");
368377

369378
ret = i2c_hid_command(client, &hid_reset_cmd, NULL, 0);

0 commit comments

Comments
 (0)