Skip to content

Commit 4c127a3

Browse files
Johannes Thumshirngregkh
authored andcommitted
qla1280: Don't allocate 512kb of host tags
commit 2bcbc81421c511ef117cadcf0bee9c4340e68db0 upstream. The qla1280 driver sets the scsi_host_template's can_queue field to 0xfffff which results in an allocation failure when allocating the block layer tags for the driver's queues. This was introduced with the change for host wide tags in commit 64d513a - "scsi: use host wide tags by default". Reduce can_queue to MAX_OUTSTANDING_COMMANDS (512) to solve the allocation error. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> Fixes: 64d513a - "scsi: use host wide tags by default" Cc: Laura Abbott <labbott@redhat.com> Cc: Michael Reed <mdr@sgi.com> Reviewed-by: Laurence Oberman <loberman@redhat.com> Reviewed-by: Lee Duncan <lduncan@suse.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: James Bottomley <jejb@linux.vnet.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 4549fc7 commit 4c127a3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/qla1280.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4214,7 +4214,7 @@ static struct scsi_host_template qla1280_driver_template = {
42144214
.eh_bus_reset_handler = qla1280_eh_bus_reset,
42154215
.eh_host_reset_handler = qla1280_eh_adapter_reset,
42164216
.bios_param = qla1280_biosparam,
4217-
.can_queue = 0xfffff,
4217+
.can_queue = MAX_OUTSTANDING_COMMANDS,
42184218
.this_id = -1,
42194219
.sg_tablesize = SG_ALL,
42204220
.use_clustering = ENABLE_CLUSTERING,

0 commit comments

Comments
 (0)