Skip to content

Commit 4e0d26b

Browse files
jgross1gregkh
authored andcommitted
xen/netback: set default upper limit of tx/rx queues to 8
[ Upstream commit 56dd5af9bc23d0d5d23bb207c477715b4c2216c5 ] The default for the maximum number of tx/rx queues of one interface is the number of cpus of the system today. As each queue pair reserves 512 grant pages this default consumes a ridiculous number of grants for large guests. Limit the queue number to 8 as default. This value can be modified via a module parameter if required. Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f3170e6 commit 4e0d26b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/net/xen-netback/netback.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ module_param(rx_drain_timeout_msecs, uint, 0444);
6767
unsigned int rx_stall_timeout_msecs = 60000;
6868
module_param(rx_stall_timeout_msecs, uint, 0444);
6969

70+
#define MAX_QUEUES_DEFAULT 8
7071
unsigned int xenvif_max_queues;
7172
module_param_named(max_queues, xenvif_max_queues, uint, 0644);
7273
MODULE_PARM_DESC(max_queues,
@@ -2157,11 +2158,12 @@ static int __init netback_init(void)
21572158
if (!xen_domain())
21582159
return -ENODEV;
21592160

2160-
/* Allow as many queues as there are CPUs if user has not
2161+
/* Allow as many queues as there are CPUs but max. 8 if user has not
21612162
* specified a value.
21622163
*/
21632164
if (xenvif_max_queues == 0)
2164-
xenvif_max_queues = num_online_cpus();
2165+
xenvif_max_queues = min_t(unsigned int, MAX_QUEUES_DEFAULT,
2166+
num_online_cpus());
21652167

21662168
if (fatal_skb_slots < XEN_NETBK_LEGACY_SLOTS_MAX) {
21672169
pr_info("fatal_skb_slots too small (%d), bump it to XEN_NETBK_LEGACY_SLOTS_MAX (%d)\n",

0 commit comments

Comments
 (0)