Skip to content

Commit 4e351b8

Browse files
yanmarkmangregkh
authored andcommitted
ARM: dts: mvebu: pl310-cache disable double-linefill
commit cda80a82ac3e89309706c027ada6ab232be1d640 upstream. Under heavy system stress mvebu SoC using Cortex A9 sporadically encountered instability issues. The "double linefill" feature of L2 cache was identified as causing dependency between read and write which lead to the deadlock. Especially, it was the cause of deadlock seen under heavy PCIe traffic, as this dependency violates PCIE overtaking rule. Fixes: c8f5a87 ("ARM: mvebu: use DT properties to fine-tune the L2 configuration") Signed-off-by: Yan Markman <ymarkman@marvell.com> Signed-off-by: Igal Liberman <igall@marvell.com> Signed-off-by: Nadav Haklai <nadavh@marvell.com> [gregory.clement@free-electrons.com: reformulate commit log, add Armada 375 and add Fixes tag] Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 581ac5f commit 4e351b8

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

arch/arm/boot/dts/armada-375.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@
176176
reg = <0x8000 0x1000>;
177177
cache-unified;
178178
cache-level = <2>;
179-
arm,double-linefill-incr = <1>;
179+
arm,double-linefill-incr = <0>;
180180
arm,double-linefill-wrap = <0>;
181-
arm,double-linefill = <1>;
181+
arm,double-linefill = <0>;
182182
prefetch-data = <1>;
183183
};
184184

arch/arm/boot/dts/armada-38x.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,9 @@
143143
reg = <0x8000 0x1000>;
144144
cache-unified;
145145
cache-level = <2>;
146-
arm,double-linefill-incr = <1>;
146+
arm,double-linefill-incr = <0>;
147147
arm,double-linefill-wrap = <0>;
148-
arm,double-linefill = <1>;
148+
arm,double-linefill = <0>;
149149
prefetch-data = <1>;
150150
};
151151

arch/arm/boot/dts/armada-39x.dtsi

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@
104104
reg = <0x8000 0x1000>;
105105
cache-unified;
106106
cache-level = <2>;
107-
arm,double-linefill-incr = <1>;
107+
arm,double-linefill-incr = <0>;
108108
arm,double-linefill-wrap = <0>;
109-
arm,double-linefill = <1>;
109+
arm,double-linefill = <0>;
110110
prefetch-data = <1>;
111111
};
112112

0 commit comments

Comments
 (0)