Skip to content

Commit 4e6cdc0

Browse files
arndbgregkh
authored andcommitted
MIPS: Lantiq: Fix another request_mem_region() return code check
[ Upstream commit 98ea51cb0c8ce009d9da1fd7b48f0ff1d7a9bbb0 ] Hauke already fixed a couple of them, but one instance remains that checks for a negative integer when it should check for a NULL pointer: arch/mips/lantiq/xway/sysctrl.c: In function 'ltq_soc_init': arch/mips/lantiq/xway/sysctrl.c:473:19: error: ordered comparison of pointer with integer zero [-Werror=extra] Fixes: 6e80785 ("MIPS: Lantiq: Fix check for return value of request_mem_region()") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: John Crispin <john@phrozen.org> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/15043/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c571039 commit 4e6cdc0

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/mips/lantiq/xway/sysctrl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -469,8 +469,8 @@ void __init ltq_soc_init(void)
469469
panic("Failed to load xbar nodes from devicetree");
470470
if (of_address_to_resource(np_xbar, 0, &res_xbar))
471471
panic("Failed to get xbar resources");
472-
if (request_mem_region(res_xbar.start, resource_size(&res_xbar),
473-
res_xbar.name) < 0)
472+
if (!request_mem_region(res_xbar.start, resource_size(&res_xbar),
473+
res_xbar.name))
474474
panic("Failed to get xbar resources");
475475

476476
ltq_xbar_membase = ioremap_nocache(res_xbar.start,

0 commit comments

Comments
 (0)