Skip to content

Commit 5228e39

Browse files
Stanimir Varbanovbjorn-helgaas
authored andcommitted
PCI: designware: Remove incorrect io_base assignment
"pp->io" is an I/O resource, e.g., "[io 0x0000-0xffff]"; "pp->io_base" is the CPU physical address of a region where the host bridge converts CPU memory accesses into PCI I/O transactions. Corrupting pp->io_base by assigning pp->io->start to it breaks access to the PCI I/O space, as reported by Kishon. Remove the invalid assignment. [bhelgaas: changelog] Fixes: 0021d22 ("PCI: designware: Use of_pci_get_host_bridge_resources() to parse DT") Reported-and-tested-by: Kishon Vijay Abraham I <kishon@ti.com> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
1 parent 3dcc8d3 commit 5228e39

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/pci/host/pcie-designware.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ int dw_pcie_host_init(struct pcie_port *pp)
440440
ret, pp->io);
441441
continue;
442442
}
443-
pp->io_base = pp->io->start;
444443
break;
445444
case IORESOURCE_MEM:
446445
pp->mem = win->res;

0 commit comments

Comments
 (0)