lightnvm: initialize ppa_addr in dev_to_generic_addr()

Javier González · gregkh · commit 5acdbe667cf4 · 2017-09-02T07:06:51.000+02:00
commit 5389a1dfb39786df08d4f6a482bd2734b1b50e33 upstream.

The -&gt;reserved bit is not initialized when allocated on stack.
This may lead targets to misinterpret the PPA as cached.

Signed-off-by: Javier González &lt;javier@cnexlabs.com&gt;
Signed-off-by: Matias Bjørling &lt;m@bjorling.me&gt;
Signed-off-by: Jens Axboe &lt;axboe@fb.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
@@ -310,6 +310,7 @@ static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev,
 {
 	struct ppa_addr l;
 
+	l.ppa = 0;
 	/*
 	 * (r.ppa << X offset) & X len bitmask. X eq. blk, pg, etc.
 	 */

Original file line number	Diff line number	Diff line change
`@@ -310,6 +310,7 @@ static inline struct ppa_addr dev_to_generic_addr(struct nvm_dev *dev,`
`310`	`310`	`{`
`311`	`311`	`struct ppa_addr l;`
`312`	`312`
	`313`	`+ l.ppa = 0;`
`313`	`314`	`/*`
`314`	`315`	`* (r.ppa << X offset) & X len bitmask. X eq. blk, pg, etc.`
`315`	`316`	`*/`