Skip to content

Commit 5efd37f

Browse files
Dan Carpentergregkh
authored andcommitted
drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()
commit 8128a31eaadbcdfa37774bbd28f3f00bac69996a upstream. c2port_device_register() never returns NULL, it uses error pointers. Link: http://lkml.kernel.org/r/20170412083321.GC3250@mwanda Fixes: 65131cd ("c2port: add c2port support for Eurotech Duramar 2150") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Rodolfo Giometti <giometti@linux.it> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ab29b21 commit 5efd37f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/misc/c2port/c2port-duramar2150.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,8 @@ static int __init duramar2150_c2port_init(void)
129129

130130
duramar2150_c2port_dev = c2port_device_register("uc",
131131
&duramar2150_c2port_ops, NULL);
132-
if (!duramar2150_c2port_dev) {
133-
ret = -ENODEV;
132+
if (IS_ERR(duramar2150_c2port_dev)) {
133+
ret = PTR_ERR(duramar2150_c2port_dev);
134134
goto free_region;
135135
}
136136

0 commit comments

Comments
 (0)