Skip to content

Commit 61fbad6

Browse files
luisbggregkh
authored andcommitted
mvsas: fix misleading indentation
commit 7789cd39274c51bf475411fe22a8ee7255082809 upstream. Fix a smatch warning: drivers/scsi/mvsas/mv_sas.c:740 mvs_task_prep() warn: curly braces intended? The code is correct, the indention is misleading. When the device is not ready we want to return SAS_PHY_DOWN. But current indentation makes it look like we only do so in the else branch of if (mvi_dev). Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 72ca0ab commit 61fbad6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/scsi/mvsas/mv_sas.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
737737
mv_dprintk("device %016llx not ready.\n",
738738
SAS_ADDR(dev->sas_addr));
739739

740-
rc = SAS_PHY_DOWN;
741-
return rc;
740+
rc = SAS_PHY_DOWN;
741+
return rc;
742742
}
743743
tei.port = dev->port->lldd_port;
744744
if (tei.port && !tei.port->port_attached && !tmf) {

0 commit comments

Comments
 (0)