dccp: fix memory leak during tear-down of unsuccessful connection request

strssndktn · gregkh · commit 676fe978525d · 2017-03-22T12:04:17.000+01:00
[ Upstream commit 72ef9c4125c7b257e3a714d62d778ab46583d6a3 ]

This patch fixes a memory leak, which happens if the connection request
is not fulfilled between parsing the DCCP options and handling the SYN
(because e.g. the backlog is full), because we forgot to free the
list of ack vectors.

Reported-by: Jianwen Ji &lt;jiji@redhat.com&gt;
Signed-off-by: Hannes Frederic Sowa &lt;hannes@stressinduktion.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c
@@ -749,6 +749,7 @@ static void ccid2_hc_tx_exit(struct sock *sk)
 	for (i = 0; i < hc->tx_seqbufc; i++)
 		kfree(hc->tx_seqbuf[i]);
 	hc->tx_seqbufc = 0;
+	dccp_ackvec_parsed_cleanup(&hc->tx_av_chunks);
 }
 
 static void ccid2_hc_rx_packet_recv(struct sock *sk, struct sk_buff *skb)

Original file line number	Diff line number	Diff line change
`@@ -749,6 +749,7 @@ static void ccid2_hc_tx_exit(struct sock *sk)`
`749`	`749`	`for (i = 0; i < hc->tx_seqbufc; i++)`
`750`	`750`	`kfree(hc->tx_seqbuf[i]);`
`751`	`751`	`hc->tx_seqbufc = 0;`
	`752`	`+ dccp_ackvec_parsed_cleanup(&hc->tx_av_chunks);`
`752`	`753`	`}`
`753`	`754`
`754`	`755`	`static void ccid2_hc_rx_packet_recv(struct sock sk, struct sk_buff skb)`