scsi: scsi_dh_emc: return success in clariion_std_inquiry()

Dan Carpenter · gregkh · commit 693e6513b244 · 2017-10-21T17:09:05.000+02:00
[ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ] We accidentally return an uninitialized variable on success. Fixes: b6ff1b1 ("[SCSI] scsi_dh: Update EMC handler") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, struct request *req)
 static int clariion_std_inquiry(struct scsi_device *sdev,
 				struct clariion_dh_data *csdev)
 {
-	int err;
+	int err = SCSI_DH_OK;
 	char *sp_model;
 
 	err = send_inquiry_cmd(sdev, 0, csdev);

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_device sdev, struct request req)`
`456`	`456`	`static int clariion_std_inquiry(struct scsi_device *sdev,`
`457`	`457`	`struct clariion_dh_data *csdev)`
`458`	`458`	`{`
`459`		`- int err;`
	`459`	`+ int err = SCSI_DH_OK;`
`460`	`460`	`char *sp_model;`
`461`	`461`
`462`	`462`	`err = send_inquiry_cmd(sdev, 0, csdev);`