Skip to content

Commit 703cfaf

Browse files
dimaepgregkh
authored andcommitted
net: mvneta: set real interrupt per packet for tx_done
commit 06708f81528725148473c0869d6af5f809c6824b upstream. Commit aebea2b ("net: mvneta: fix Tx interrupt delay") intended to set coalescing threshold to a value guaranteeing interrupt generation per each sent packet, so that buffers can be released with no delay. In fact setting threshold to '1' was wrong, because it causes interrupt every two packets. According to the documentation a reason behind it is following - interrupt occurs once sent buffers counter reaches a value, which is higher than one specified in MVNETA_TXQ_SIZE_REG(q). This behavior was confirmed during tests. Also when testing the SoC working as a NAS device, better performance was observed with int-per-packet, as it strongly depends on the fact that all transmitted packets are released immediately. This commit enables NETA controller work in interrupt per sent packet mode by setting coalescing threshold to 0. Signed-off-by: Dmitri Epshtein <dima@marvell.com> Signed-off-by: Marcin Wojtas <mw@semihalf.com> Fixes aebea2b ("net: mvneta: fix Tx interrupt delay") Acked-by: Willy Tarreau <w@1wt.eu> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 032951d commit 703cfaf

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/marvell/mvneta.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@
226226
/* Various constants */
227227

228228
/* Coalescing */
229-
#define MVNETA_TXDONE_COAL_PKTS 1
229+
#define MVNETA_TXDONE_COAL_PKTS 0 /* interrupt per packet */
230230
#define MVNETA_RX_COAL_PKTS 32
231231
#define MVNETA_RX_COAL_USEC 100
232232

0 commit comments

Comments
 (0)