Skip to content

Commit 7075262

Browse files
hayesorzgregkh
authored andcommitted
r8152: avoid start_xmit to schedule napi when napi is disabled
[ Upstream commit de9bf29dd6e4a8a874cb92f8901aed50a9d0b1d3 ] Stop the tx when the napi is disabled to prevent napi_schedule() is called. Signed-off-by: Hayes Wang <hayeswang@realtek.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 5270bf6 commit 7075262

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/net/usb/r8152.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2993,17 +2993,21 @@ static void set_carrier(struct r8152 *tp)
29932993
if (!netif_carrier_ok(netdev)) {
29942994
tp->rtl_ops.enable(tp);
29952995
set_bit(RTL8152_SET_RX_MODE, &tp->flags);
2996+
netif_stop_queue(netdev);
29962997
napi_disable(&tp->napi);
29972998
netif_carrier_on(netdev);
29982999
rtl_start_rx(tp);
29993000
napi_enable(&tp->napi);
3001+
netif_wake_queue(netdev);
3002+
netif_info(tp, link, netdev, "carrier on\n");
30003003
}
30013004
} else {
30023005
if (netif_carrier_ok(netdev)) {
30033006
netif_carrier_off(netdev);
30043007
napi_disable(&tp->napi);
30053008
tp->rtl_ops.disable(tp);
30063009
napi_enable(&tp->napi);
3010+
netif_info(tp, link, netdev, "carrier off\n");
30073011
}
30083012
}
30093013
}
@@ -3388,12 +3392,12 @@ static int rtl8152_pre_reset(struct usb_interface *intf)
33883392
if (!netif_running(netdev))
33893393
return 0;
33903394

3395+
netif_stop_queue(netdev);
33913396
napi_disable(&tp->napi);
33923397
clear_bit(WORK_ENABLE, &tp->flags);
33933398
usb_kill_urb(tp->intr_urb);
33943399
cancel_delayed_work_sync(&tp->schedule);
33953400
if (netif_carrier_ok(netdev)) {
3396-
netif_stop_queue(netdev);
33973401
mutex_lock(&tp->control);
33983402
tp->rtl_ops.disable(tp);
33993403
mutex_unlock(&tp->control);
@@ -3421,10 +3425,10 @@ static int rtl8152_post_reset(struct usb_interface *intf)
34213425
rtl_start_rx(tp);
34223426
rtl8152_set_rx_mode(netdev);
34233427
mutex_unlock(&tp->control);
3424-
netif_wake_queue(netdev);
34253428
}
34263429

34273430
napi_enable(&tp->napi);
3431+
netif_wake_queue(netdev);
34283432
usb_submit_urb(tp->intr_urb, GFP_KERNEL);
34293433

34303434
return 0;

0 commit comments

Comments
 (0)