Skip to content

Commit 72906ce

Browse files
crdbehrMark Yao
authored andcommitted
drm/rockchip: vop: fix window origin calculation
VOP_WINx_DSP_ST does not require subtracting 1 from the values written to it. It actually causes the screen to be shifted by one pixel. Signed-off-by: Mark Yao <mark.yao@rock-chips.com> Tested-by: Yakir Yang <ykk@rock-chips.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> Tested-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Dominik Behr <dbehr@chromium.org> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
1 parent a8594f2 commit 72906ce

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/rockchip/rockchip_drm_vop.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -959,8 +959,8 @@ static int vop_update_plane_event(struct drm_plane *plane,
959959
val = (dest.y2 - dest.y1 - 1) << 16;
960960
val |= (dest.x2 - dest.x1 - 1) & 0xffff;
961961
VOP_WIN_SET(vop, win, dsp_info, val);
962-
val = (dsp_sty - 1) << 16;
963-
val |= (dsp_stx - 1) & 0xffff;
962+
val = dsp_sty << 16;
963+
val |= dsp_stx & 0xffff;
964964
VOP_WIN_SET(vop, win, dsp_st, val);
965965
VOP_WIN_SET(vop, win, rb_swap, rb_swap);
966966

0 commit comments

Comments
 (0)