Skip to content

Commit 76c389c

Browse files
jhovoldgregkh
authored andcommitted
NFC: fix device-allocation error return
commit c45e3e4c5b134b081e8af362109905427967eb19 upstream. A recent change fixing NFC device allocation itself introduced an error-handling bug by returning an error pointer in case device-id allocation failed. This is clearly broken as the callers still expected NULL to be returned on errors as detected by Dan's static checker. Fix this up by returning NULL in the event that we've run out of memory when allocating a new device id. Note that the offending commit is marked for stable (3.8) so this fix needs to be backported along with it. Fixes: 20777bc57c34 ("NFC: fix broken device allocation") Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ecc5e89 commit 76c389c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/nfc/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1093,7 +1093,7 @@ struct nfc_dev *nfc_allocate_device(struct nfc_ops *ops,
10931093
err_free_dev:
10941094
kfree(dev);
10951095

1096-
return ERR_PTR(rc);
1096+
return NULL;
10971097
}
10981098
EXPORT_SYMBOL(nfc_allocate_device);
10991099

0 commit comments

Comments
 (0)