Skip to content

Commit 7847c9b

Browse files
David Rivshinrkhuangtao
authored andcommitted
UPSTREAM: leds: Add SN3218 and SN3216 support to the IS31FL32XX driver
Si-En Technology was acquired by ISSI in 2011, and it appears that the IS31FL3218/IS31FL3216 are just rebranded SN3218/SN3216 devices. Add the "si-en,sn3218" and "si-en,sn3216" compatible strings into the IS31FL32XX driver as aliases for the issi equivalents, and update binding documentation. Datasheets: IS31FL3218: http://www.issi.com/WW/pdf/31FL3218.pdf SN3218: http://www.si-en.com/uploadpdf/s2011517171720.pdf IS31FL3216: http://www.issi.com/WW/pdf/31FL3216.pdf SN3216: http://www.si-en.com/uploadpdf/SN3216201152410148.pdf Change-Id: I05a6e3e618daf2499c2d303f265aaae5cdb4ed85 Signed-off-by: David Rivshin <drivshin@allworx.com> Acked-by: Rob Herring <robh@kernel.org> Tested-by: Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> Signed-off-by: Wenping Zhang <wenping.zhang@rock-chips.com> (cherry picked from commit e0442d7def8f9dccde0d825a01d8a6951aa6e95d)
1 parent 1d2ba72 commit 7847c9b

3 files changed

Lines changed: 14 additions & 7 deletions

File tree

Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Binding for ISSI IS31FL32xx LED Drivers
1+
Binding for ISSI IS31FL32xx and Si-En SN32xx LED Drivers
22

3-
The IS31FL32xx family of LED drivers are I2C devices with multiple
3+
The IS31FL32xx/SN32xx family of LED drivers are I2C devices with multiple
44
constant-current channels, each with independent 256-level PWM control.
55
Each LED is represented as a sub-node of the device.
66

@@ -10,6 +10,8 @@ Required properties:
1010
issi,is31fl3235
1111
issi,is31fl3218
1212
issi,is31fl3216
13+
si-en,sn3218
14+
si-en,sn3216
1315
- reg: I2C slave address
1416
- address-cells : must be 1
1517
- size-cells : must be 0
@@ -45,5 +47,6 @@ is31fl3236: led-controller@3c {
4547
};
4648
};
4749

48-
For more product information please see the link below:
50+
For more product information please see the links below:
4951
http://www.issi.com/US/product-analog-fxled-driver.shtml
52+
http://www.si-en.com/product.asp?parentid=890

drivers/leds/Kconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -570,9 +570,9 @@ config LEDS_IS31FL32XX
570570
tristate "LED support for ISSI IS31FL32XX I2C LED controller family"
571571
depends on LEDS_CLASS && I2C && OF
572572
help
573-
Say Y here to include support for ISSI IS31FL32XX LED controllers.
574-
They are I2C devices with multiple constant-current channels, each
575-
with independent 256-level PWM control.
573+
Say Y here to include support for ISSI IS31FL32XX and Si-En SN32xx
574+
LED controllers. They are I2C devices with multiple constant-current
575+
channels, each with independent 256-level PWM control.
576576

577577
comment "LED driver for blink(1) USB RGB LED is under Special HID drivers (HID_THINGM)"
578578

drivers/leds/leds-is31fl32xx.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,9 @@
88
* it under the terms of the GNU General Public License version 2 as
99
* published by the Free Software Foundation.
1010
*
11-
* Datasheets: http://www.issi.com/US/product-analog-fxled-driver.shtml
11+
* Datasheets:
12+
* http://www.issi.com/US/product-analog-fxled-driver.shtml
13+
* http://www.si-en.com/product.asp?parentid=890
1214
*/
1315

1416
#include <linux/device.h>
@@ -424,7 +426,9 @@ static const struct of_device_id of_is31fl31xx_match[] = {
424426
{ .compatible = "issi,is31fl3236", .data = &is31fl3236_cdef, },
425427
{ .compatible = "issi,is31fl3235", .data = &is31fl3235_cdef, },
426428
{ .compatible = "issi,is31fl3218", .data = &is31fl3218_cdef, },
429+
{ .compatible = "si-en,sn3218", .data = &is31fl3218_cdef, },
427430
{ .compatible = "issi,is31fl3216", .data = &is31fl3216_cdef, },
431+
{ .compatible = "si-en,sn3216", .data = &is31fl3216_cdef, },
428432
{},
429433
};
430434

0 commit comments

Comments
 (0)