Skip to content

Commit 792f1fe

Browse files
KAGA-KOKOgregkh
authored andcommitted
pinctrl: samsung: Remove bogus irq_[un]mask from resource management
commit 3fa53ec2ed885b0aec3f0472e3b4a8a6f1cd748c upstream. The irq chip callbacks irq_request/release_resources() have absolutely no business with masking and unmasking the irq. The core code unmasks the interrupt after complete setup and masks it before invoking irq_release_resources(). The unmask is actually harmful as it happens before the interrupt is completely initialized in __setup_irq(). Remove it. Fixes: f6a8249 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs") Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Kukjin Kim <kgene@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Acked-by: Tomasz Figa <tomasz.figa@gmail.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 6f51066 commit 792f1fe

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/pinctrl/samsung/pinctrl-exynos.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,6 @@ static int exynos_irq_request_resources(struct irq_data *irqd)
194194

195195
spin_unlock_irqrestore(&bank->slock, flags);
196196

197-
exynos_irq_unmask(irqd);
198-
199197
return 0;
200198
}
201199

@@ -216,8 +214,6 @@ static void exynos_irq_release_resources(struct irq_data *irqd)
216214
shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];
217215
mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;
218216

219-
exynos_irq_mask(irqd);
220-
221217
spin_lock_irqsave(&bank->slock, flags);
222218

223219
con = readl(d->virt_base + reg_con);

0 commit comments

Comments
 (0)