Skip to content

Commit 7c7a0e9

Browse files
g00308965bjorn-helgaas
authored andcommitted
ARM/PCI: Move align_resource function pointer to pci_host_bridge structure
Commit b3a7238 ("ARM/PCI: Replace pci_sys_data->align_resource with global function pointer") introduced an ARM-specific align_resource() function pointer. This is not portable to other arches and doesn't work for platforms with two different PCIe host bridge controllers. Move the function pointer to the pci_host_bridge structure so each host bridge driver can specify its own align_resource() function. Signed-off-by: Gabriele Paoloni <gabriele.paoloni@huawei.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
1 parent 9f55cf5 commit 7c7a0e9

3 files changed

Lines changed: 20 additions & 10 deletions

File tree

arch/arm/kernel/bios32.c

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
#include <asm/mach/pci.h>
1818

1919
static int debug_pci;
20-
static resource_size_t (*align_resource)(struct pci_dev *dev,
21-
const struct resource *res,
22-
resource_size_t start,
23-
resource_size_t size,
24-
resource_size_t align) = NULL;
2520

2621
/*
2722
* We can't use pci_get_device() here since we are
@@ -461,7 +456,6 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw,
461456
sys->busnr = busnr;
462457
sys->swizzle = hw->swizzle;
463458
sys->map_irq = hw->map_irq;
464-
align_resource = hw->align_resource;
465459
INIT_LIST_HEAD(&sys->resources);
466460

467461
if (hw->private_data)
@@ -470,6 +464,8 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw,
470464
ret = hw->setup(nr, sys);
471465

472466
if (ret > 0) {
467+
struct pci_host_bridge *host_bridge;
468+
473469
ret = pcibios_init_resources(nr, sys);
474470
if (ret) {
475471
kfree(sys);
@@ -491,6 +487,9 @@ static void pcibios_init_hw(struct device *parent, struct hw_pci *hw,
491487
busnr = sys->bus->busn_res.end + 1;
492488

493489
list_add(&sys->node, head);
490+
491+
host_bridge = pci_find_host_bridge(sys->bus);
492+
host_bridge->align_resource = hw->align_resource;
494493
} else {
495494
kfree(sys);
496495
if (ret < 0)
@@ -578,14 +577,18 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,
578577
{
579578
struct pci_dev *dev = data;
580579
resource_size_t start = res->start;
580+
struct pci_host_bridge *host_bridge;
581581

582582
if (res->flags & IORESOURCE_IO && start & 0x300)
583583
start = (start + 0x3ff) & ~0x3ff;
584584

585585
start = (start + align - 1) & ~(align - 1);
586586

587-
if (align_resource)
588-
return align_resource(dev, res, start, size, align);
587+
host_bridge = pci_find_host_bridge(dev->bus);
588+
589+
if (host_bridge->align_resource)
590+
return host_bridge->align_resource(dev, res,
591+
start, size, align);
589592

590593
return start;
591594
}

drivers/pci/pci.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,4 @@ static inline int pci_dev_specific_reset(struct pci_dev *dev, int probe)
337337
}
338338
#endif
339339

340-
struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus);
341-
342340
#endif /* DRIVERS_PCI_H */

include/linux/pci.h

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -412,9 +412,18 @@ struct pci_host_bridge {
412412
void (*release_fn)(struct pci_host_bridge *);
413413
void *release_data;
414414
unsigned int ignore_reset_delay:1; /* for entire hierarchy */
415+
/* Resource alignment requirements */
416+
resource_size_t (*align_resource)(struct pci_dev *dev,
417+
const struct resource *res,
418+
resource_size_t start,
419+
resource_size_t size,
420+
resource_size_t align);
415421
};
416422

417423
#define to_pci_host_bridge(n) container_of(n, struct pci_host_bridge, dev)
424+
425+
struct pci_host_bridge *pci_find_host_bridge(struct pci_bus *bus);
426+
418427
void pci_set_host_bridge_release(struct pci_host_bridge *bridge,
419428
void (*release_fn)(struct pci_host_bridge *),
420429
void *release_data);

0 commit comments

Comments
 (0)