Skip to content

Commit 7cd8c49

Browse files
Doug Bergergregkh
authored andcommitted
ARM: 8685/1: ensure memblock-limit is pmd-aligned
commit 9e25ebfe56ece7541cd10a20d715cbdd148a2e06 upstream. The pmd containing memblock_limit is cleared by prepare_page_table() which creates the opportunity for early_alloc() to allocate unmapped memory if memblock_limit is not pmd aligned causing a boot-time hang. Commit 965278d ("ARM: 8356/1: mm: handle non-pmd-aligned end of RAM") attempted to resolve this problem, but there is a path through the adjust_lowmem_bounds() routine where if all memory regions start and end on pmd-aligned addresses the memblock_limit will be set to arm_lowmem_limit. Since arm_lowmem_limit can be affected by the vmalloc early parameter, the value of arm_lowmem_limit may not be pmd-aligned. This commit corrects this oversight such that memblock_limit is always rounded down to pmd-alignment. Fixes: 965278d ("ARM: 8356/1: mm: handle non-pmd-aligned end of RAM") Signed-off-by: Doug Berger <opendmb@gmail.com> Suggested-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d4960d5 commit 7cd8c49

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

arch/arm/mm/mmu.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1184,15 +1184,15 @@ void __init sanity_check_meminfo(void)
11841184

11851185
high_memory = __va(arm_lowmem_limit - 1) + 1;
11861186

1187+
if (!memblock_limit)
1188+
memblock_limit = arm_lowmem_limit;
1189+
11871190
/*
11881191
* Round the memblock limit down to a pmd size. This
11891192
* helps to ensure that we will allocate memory from the
11901193
* last full pmd, which should be mapped.
11911194
*/
1192-
if (memblock_limit)
1193-
memblock_limit = round_down(memblock_limit, PMD_SIZE);
1194-
if (!memblock_limit)
1195-
memblock_limit = arm_lowmem_limit;
1195+
memblock_limit = round_down(memblock_limit, PMD_SIZE);
11961196

11971197
memblock_set_current_limit(memblock_limit);
11981198
}

0 commit comments

Comments
 (0)