Skip to content

Commit 7d13060

Browse files
YiChongZhjamess-huang
authored andcommitted
media: rockchip: isp1: Update new ISP parameters immediately
For those sub modules that have shadow registers in core isp, the new programing parameters would not be active if both CIF_ISP_CTRL_ISP_CFG_UPD_PERMANENT and CFG_UPD are not set. Now we configure CFG_UPD to force update the shadow registers when new ISP parameters are configured. BUG=b:36227021 TEST=scarlet can preview, LSC data table can be switched. Change-Id: I804ddfc45b3c2fca9a6f51627af4264a25075070 Signed-off-by: ZhongYiChong <zyc@rock-chips.com> Reviewed-on: https://tp-biosrd-v02/gerrit/82867 Reviewed-by: Jamess Huang(黃以民) <Jamess_Huang@asus.com> Tested-by: Jamess Huang(黃以民) <Jamess_Huang@asus.com>
1 parent 1868620 commit 7d13060

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

drivers/media/platform/rockchip/isp1/isp_params.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,8 +1189,16 @@ void rkisp1_params_isr(struct rkisp1_isp_params_vdev *params_vdev, u32 isp_mis)
11891189
new_params = (struct rkisp1_isp_params_cfg *)(cur_buf->vaddr[0]);
11901190

11911191
if (isp_mis & CIF_ISP_FRAME) {
1192+
u32 isp_ctrl;
1193+
11921194
__isp_isr_other_config(params_vdev, new_params);
11931195
__isp_isr_meas_config(params_vdev, new_params);
1196+
1197+
/* update shadow register immediately */
1198+
isp_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_CTRL);
1199+
isp_ctrl |= CIF_ISP_CTRL_ISP_CFG_UPD;
1200+
rkisp1_iowrite32(params_vdev, isp_ctrl, CIF_ISP_CTRL);
1201+
11941202
spin_lock(&params_vdev->config_lock);
11951203
list_del(&cur_buf->queue);
11961204
spin_unlock(&params_vdev->config_lock);

0 commit comments

Comments
 (0)