Skip to content

Commit 7e78922

Browse files
Jarkko Sakkinengregkh
authored andcommitted
tpm: fix a kernel memory leak in tpm-sysfs.c
commit 13b47cfcfc60495cde216eef4c01040d76174cbe upstream. While cleaning up sysfs callback that prints EK we discovered a kernel memory leak. This commit fixes the issue by zeroing the buffer used for TPM command/response. The leak happen when we use either tpm_vtpm_proxy, tpm_ibmvtpm or xen-tpmfront. Fixes: 0883743 ("TPM: sysfs functions consolidation") Reported-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Tested-by: Stefan Berger <stefanb@linux.vnet.ibm.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: James Morris <james.l.morris@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 366f501 commit 7e78922

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/char/tpm/tpm-sysfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ static ssize_t pubek_show(struct device *dev, struct device_attribute *attr,
3838

3939
struct tpm_chip *chip = dev_get_drvdata(dev);
4040

41+
memset(&tpm_cmd, 0, sizeof(tpm_cmd));
42+
4143
tpm_cmd.header.in = tpm_readpubek_header;
4244
err = tpm_transmit_cmd(chip, &tpm_cmd, READ_PUBEK_RESULT_SIZE, 0,
4345
"attempting to read the PUBEK");

0 commit comments

Comments
 (0)