Skip to content

Commit 800791e

Browse files
anderssongregkh
authored andcommitted
pinctrl: qcom: Don't clear status bit on irq_unmask
commit a6566710adaa4a7dd5e0d99820ff9c9c30ee5951 upstream. Clearing the status bit on irq_unmask will discard any pending interrupt that did arrive after the irq_ack, i.e. while the IRQ handler function was executing. Fixes: f365be0 ("pinctrl: Add Qualcomm TLMM driver") Cc: Stephen Boyd <sboyd@codeaurora.org> Reported-by: Timur Tabi <timur@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 927d047 commit 800791e

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/pinctrl/qcom/pinctrl-msm.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -597,10 +597,6 @@ static void msm_gpio_irq_unmask(struct irq_data *d)
597597

598598
spin_lock_irqsave(&pctrl->lock, flags);
599599

600-
val = readl(pctrl->regs + g->intr_status_reg);
601-
val &= ~BIT(g->intr_status_bit);
602-
writel(val, pctrl->regs + g->intr_status_reg);
603-
604600
val = readl(pctrl->regs + g->intr_cfg_reg);
605601
val |= BIT(g->intr_enable_bit);
606602
writel(val, pctrl->regs + g->intr_cfg_reg);

0 commit comments

Comments
 (0)