staging: iio: cdc: fix improper return value

SinkFinder · gregkh · commit 8537e96e4351 · 2017-11-30T08:37:27.000Z
[ Upstream commit 91ca1a8c584f55857b1f6ab20a1d3a1ce7a559bb ]

At the end of function ad7150_write_event_config(), directly returns 0.
As a result, the errors will be ignored by the callers. It may be better
to return variable "ret".

Signed-off-by: Pan Bian &lt;bianpan2016@163.com&gt;
Signed-off-by: Jonathan Cameron &lt;jic23@kernel.org&gt;
Signed-off-by: Sasha Levin &lt;alexander.levin@verizon.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/iio/cdc/ad7150.c b/drivers/staging/iio/cdc/ad7150.c
@@ -272,7 +272,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
 error_ret:
 	mutex_unlock(&chip->state_lock);
 
-	return 0;
+	return ret;
 }
 
 static int ad7150_read_event_value(struct iio_dev *indio_dev,

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,`
`272`	`272`	`error_ret:`
`273`	`273`	`mutex_unlock(&chip->state_lock);`
`274`	`274`
`275`		`- return 0;`
	`275`	`+ return ret;`
`276`	`276`	`}`
`277`	`277`
`278`	`278`	`static int ad7150_read_event_value(struct iio_dev *indio_dev,`