Skip to content

Commit 8a56b1b

Browse files
larsclausengregkh
authored andcommitted
adv7604: Initialize drive strength to default when using DT
[ Upstream commit da8892d410db224d9a24104529794e6e37e0c100 ] The adv7604 driver platform data contains fields for configuring the drive strength of the output pins. When probing the driver through DT these fields are not explicitly initialized, which means they are left at 0. This is a reserved setting for the drive strength configuration though and can cause signal integrity issues. Whether these signal integrity issues are visible depends on the PCB specifics (e.g. the higher the load capacitance for the output the more visible the issue). But it has been observed on existing solutions at high pixel clock rates. Initialize the drive strength settings to the power-on-reset value of the device when probing through devicetree to avoid this issue. Fixes: 0e158be0162b ("adv7604: Add DT support") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c54d070 commit 8a56b1b

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

drivers/media/i2c/adv7604.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2856,6 +2856,9 @@ static int adv76xx_parse_dt(struct adv76xx_state *state)
28562856
state->pdata.alt_data_sat = 1;
28572857
state->pdata.op_format_mode_sel = ADV7604_OP_FORMAT_MODE0;
28582858
state->pdata.bus_order = ADV7604_BUS_ORDER_RGB;
2859+
state->pdata.dr_str_data = ADV76XX_DR_STR_MEDIUM_HIGH;
2860+
state->pdata.dr_str_clk = ADV76XX_DR_STR_MEDIUM_HIGH;
2861+
state->pdata.dr_str_sync = ADV76XX_DR_STR_MEDIUM_HIGH;
28592862

28602863
return 0;
28612864
}

0 commit comments

Comments
 (0)