Skip to content

Commit 8db0075

Browse files
Catramengregkh
authored andcommitted
Input: drv260x - fix input device's parent assignment
commit 5a8a6b89c15766446d845671d574a9243b6d8786 upstream. We were assigning I2C bus controller instead of client as parent device. Besides being logically wrong, it messed up with devm handling of input device. As a result we were leaving input device and event node behind after rmmod-ing the driver, which lead to a kernel oops if one were to access the event node later. Let's remove the assignment and rely on devm_input_allocate_device() to set it up properly for us. Signed-off-by: Jingkui Wang <jkwang@google.com> Fixes: 7132fe4 ("Input: drv260x - add TI drv260x haptics driver") Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 44685f0 commit 8db0075

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/input/misc/drv260x.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,6 @@ static int drv260x_probe(struct i2c_client *client,
592592
}
593593

594594
haptics->input_dev->name = "drv260x:haptics";
595-
haptics->input_dev->dev.parent = client->dev.parent;
596595
haptics->input_dev->close = drv260x_close;
597596
input_set_drvdata(haptics->input_dev, haptics);
598597
input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);

0 commit comments

Comments
 (0)