Skip to content

Commit 8e69544

Browse files
ideakjnikula
authored andcommitted
drm/i915: add MISSING_CASE to a few port/aux power domain helpers
MISSING_CASE() would have been useful to track down a recent problem in intel_display_port_aux_power_domain(), so add it there and a few related helpers. This was also suggested by Ville in his review of the latest DMC/DC changes, we forgot to address that. Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com> [Cherry-picked from drm-intel-next-queued b9fec167 (Imre)] Signed-off-by: Imre Deak <imre.deak@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/1448643329-18675-5-git-send-email-imre.deak@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent 88747f1 commit 8e69544

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/i915/intel_display.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5194,7 +5194,7 @@ static enum intel_display_power_domain port_to_power_domain(enum port port)
51945194
case PORT_E:
51955195
return POWER_DOMAIN_PORT_DDI_E_2_LANES;
51965196
default:
5197-
WARN_ON_ONCE(1);
5197+
MISSING_CASE(port);
51985198
return POWER_DOMAIN_PORT_OTHER;
51995199
}
52005200
}
@@ -5214,7 +5214,7 @@ static enum intel_display_power_domain port_to_aux_power_domain(enum port port)
52145214
/* FIXME: Check VBT for actual wiring of PORT E */
52155215
return POWER_DOMAIN_AUX_D;
52165216
default:
5217-
WARN_ON_ONCE(1);
5217+
MISSING_CASE(port);
52185218
return POWER_DOMAIN_AUX_A;
52195219
}
52205220
}
@@ -5275,7 +5275,7 @@ intel_display_port_aux_power_domain(struct intel_encoder *intel_encoder)
52755275
intel_dig_port = enc_to_mst(&intel_encoder->base)->primary;
52765276
return port_to_aux_power_domain(intel_dig_port->port);
52775277
default:
5278-
WARN_ON_ONCE(1);
5278+
MISSING_CASE(intel_encoder->type);
52795279
return POWER_DOMAIN_AUX_A;
52805280
}
52815281
}

0 commit comments

Comments
 (0)