Skip to content

Commit 8edc7f0

Browse files
arndbgregkh
authored andcommitted
gcov: disable tree-loop-im to reduce stack usage
commit c87bf431448b404a6ef5fbabd74c0e3e42157a7f upstream. Enabling CONFIG_GCOV_PROFILE_ALL produces us a lot of warnings like lib/lz4/lz4hc_compress.c: In function 'lz4_compresshcctx': lib/lz4/lz4hc_compress.c:514:1: warning: the frame size of 1504 bytes is larger than 1024 bytes [-Wframe-larger-than=] After some investigation, I found that this behavior started with gcc-4.9, and opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69702. A suggested workaround for it is to use the -fno-tree-loop-im flag that turns off one of the optimization stages in gcc, so the code runs a little slower but does not use excessive amounts of stack. We could make this conditional on the gcc version, but I could not find an easy way to do this in Kbuild and the benefit would be fairly small, given that most of the gcc version in production are affected now. I'm marking this for 'stable' backports because it addresses a bug with code generation in gcc that exists in all kernel versions with the affected gcc releases. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com> Signed-off-by: Michal Marek <mmarek@suse.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 4b2fb17 commit 8edc7f0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ AFLAGS_MODULE =
364364
LDFLAGS_MODULE =
365365
CFLAGS_KERNEL =
366366
AFLAGS_KERNEL =
367-
CFLAGS_GCOV = -fprofile-arcs -ftest-coverage
367+
CFLAGS_GCOV = -fprofile-arcs -ftest-coverage -fno-tree-loop-im
368368

369369

370370
# Use USERINCLUDE when you must reference the UAPI directories only.

0 commit comments

Comments
 (0)