Skip to content

Commit 96cdeaa

Browse files
zheng ligregkh
authored andcommitted
ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output
commit 0a28cfd51e17f4f0a056bcf66bfbe492c3b99f38 upstream. There is an inconsistent conditional judgement in __ip_append_data and ip_finish_output functions, the variable length in __ip_append_data just include the length of application's payload and udp header, don't include the length of ip header, but in ip_finish_output use (skb->len > ip_skb_dst_mtu(skb)) as judgement, and skb->len include the length of ip header. That causes some particular application's udp payload whose length is between (MTU - IP Header) and MTU were fragmented by ip_fragment even though the rst->dev support UFO feature. Add the length of ip header to length in __ip_append_data to keep consistent conditional judgement as ip_finish_output for ip fragment. Signed-off-by: Zheng Li <james.z.li@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d45aaba commit 96cdeaa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

net/ipv4/ip_output.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ static int __ip_append_data(struct sock *sk,
923923

924924
cork->length += length;
925925
if ((skb && skb_is_gso(skb)) ||
926-
((length > mtu) &&
926+
(((length + fragheaderlen) > mtu) &&
927927
(skb_queue_len(queue) <= 1) &&
928928
(sk->sk_protocol == IPPROTO_UDP) &&
929929
(rt->dst.dev->features & NETIF_F_UFO) && !rt->dst.header_len &&

0 commit comments

Comments
 (0)